search

hectorcorrea / marcli

MARC command line parser
MIT License
117 stars 8 forks source link

tweak check subfield #4

Closed sunshineplan closed 3 years ago

sunshineplan commented 3 years ago

Fixes #3 and doesn't allow blank data element

sunshineplan commented 3 years ago

According the specification:The data element may be any ASCII lowercase alphabetic, numeric, or graphic symbol except blank.

hectorcorrea commented 3 years ago

@sunshineplan thank you very much for this PR.

I am sorry I had not gotten back to you sooner, I had notifications turned off and did not see your PR until today. I should get back with you soon.

sunshineplan commented 3 years ago

I'm glad to hear that. This PR's aim is don't interrupt the process of reading whole file. Some illegal data will be ignored. And add some length checking to avoid unexpected panic.