Closed cosmastech closed 9 months ago
@hedhyw This is my first major contribution to anything in Golang. I hope that I didn't make too much of a mess of anything (especially the tests!).
Look forward to your review notes 🙏
make lint
locally to fix "check-json-log-viewer / Test (pull_request)".
one more thing there is a test example ExampleGetDefaultConfig
, kind should be updated there.
Thanks @hedhyw! Ready for a final pass.
To resolve https://github.com/hedhyw/json-log-viewer/issues/36
This is my first time working on anything in Go, so I would appreciate any pointers. Thanks for the opportunity to work on this!