feat: support human readable timestamps

hedhyw / json-log-viewer

Interactive viewer for JSON logs.

MIT License

77 stars 7 forks source link

Closed cosmastech closed 9 months ago

cosmastech commented 9 months ago

This is my first time working on anything in Go, so I would appreciate any pointers. Thanks for the opportunity to work on this!

cosmastech commented 9 months ago

@hedhyw This is my first major contribution to anything in Golang. I hope that I didn't make too much of a mess of anything (especially the tests!).

Look forward to your review notes 🙏

hedhyw commented 9 months ago

Please rename the PR to "feat: support human readable timestamps" in order to fix "check-pr-semantic / Validate PR title (pull_request)".
and try to run make lint locally to fix "check-json-log-viewer / Test (pull_request)".

hedhyw commented 9 months ago

one more thing there is a test example ExampleGetDefaultConfig, kind should be updated there.

cosmastech commented 9 months ago

Thanks @hedhyw! Ready for a final pass.