search

heimrichhannot / contao-utils-bundle

This bundle offers various utility functionality for the Contao CMS.
GNU Lesser General Public License v3.0
8 stars 4 forks source link

add missing parameters diskcache and pdfa to create Fpdi object #10

Closed homberger closed 5 years ago

homberger commented 5 years ago

Fixes #11

Defcon0 commented 5 years ago

What error is being thrown and in which use case? I used the class already without issues.

homberger commented 5 years ago

What error is being thrown and in which use case? I used the class already without issues.

The linked issue of my pull request was a different issue. I created issue #11

This was a regular composer update.

koertho commented 5 years ago

The two parameters added in this pull request are not necessarily needed, as they are the default value from the tcpdf constructor. The error is the trailing comma in the constructor parameters, which isn't supported until PHP 7.4. So I would prefer to just remove the trailing comma.

homberger commented 5 years ago

The two parameters added in this pull request are not necessarily needed, as they are the default value from the tcpdf constructor. The error is the trailing comma in the constructor parameters, which isn't supported until PHP 7.4. So I would prefer to just remove the trailing comma.

Oh, I see! Thank you! :)