Fix a potential error upon cache warmup and a missing system/tmp folder

heimrichhannot / contao-utils-bundle

This bundle offers various utility functionality for the Contao CMS.

GNU Lesser General Public License v3.0

8 stars 4 forks source link

Fix a potential error upon cache warmup and a missing system/tmp folder #43

Closed qzminski closed 2 years ago

qzminski commented 2 years ago

If there is no system/tmp folder available and you try to warmup the cache, it will result in an error. This PR should fix that.

Ideally, this logic should be changed to not use Contao local config, but rather some service like DatabaseCacheUtil::getDbCacheMaxTime() which checks if local config value exists, otherwise returns a default value.

koertho commented 2 years ago

Thanks for your contribution! Yes, a change like you suggested would be good, but to be honest, I don't know it this utils is need anymore so maybe we can remove it in version 3. But I will put your idea in an issue, maybe my future me or someone find time to implement your idea :)