gamenet: invalidid -> invalid id

heinrich5991 / libtw2

Some Teeworlds stuff in Rust.™

Apache License 2.0

49 stars 17 forks source link

gamenet: invalidid -> invalid id #102

Closed ChillerDragon closed 2 months ago

ChillerDragon commented 3 months ago

Drunk teeworlds devs thought invalidid is one word. Can we fix that in libtw2?

https://github.com/heinrich5991/libtw2/blob/f3c8840d756bc06e436656c16f48f02bcb4ce8b3/gamenet/generate/spec/teeworlds-0.7.5.json#L84

heinrich5991 commented 3 months ago

Since that is generated, it should probably be fixed in upstream instead. Any changes there will be reflected here. Upstream is obviously unresponsive though.

https://github.com/teeworlds/teeworlds/blob/a1911c8f7d8458fb4076ef8e7651e8ef5e91ab3e/datasrc/network.py#L15C45-L15C59

heinrich5991 commented 2 months ago

@ChillerDragon Could you open an upstream PR?

ChillerDragon commented 2 months ago

https://github.com/teeworlds/teeworlds/pull/3251

ChillerDragon commented 2 months ago

lez go its merged upstream