search

helge17 / tuxguitar

Improve TuxGuitar and provide builds
Other
496 stars 43 forks source link

The right scroll bar is not available during play #503

Closed ycollet closed 1 month ago

ycollet commented 2 months ago

With the last version of tuxguitar (1.6.4), the right scroll bar is not available when the score is in play mode. Once the score is stopped, the scroll bar reappears ... I use KDE on Fedora 40 with the tuxguitar package provided with Audinux repository. This package has been compiled with swt 4.26.

guiv42 commented 2 months ago

Yep, this is purely intentional.

You can fin more detailed explanation in #403. I spent a lot of time on this performance issue. Basically the scrollbars induce a very significant performance issue with recent versions of SWT.

ycollet commented 2 months ago

OK. I used the scroll bar to recenter the score during pause ... I will try to find another solution :)

guiv42 commented 2 months ago

Sorry I don't understand.

I used the scroll bar to recenter the score during pause ...

The scrollbar(s) is (are) supposed to be visible when you pause

https://github.com/user-attachments/assets/4df19759-6abd-48f1-8b9c-de5194281a95

ycollet commented 2 months ago

I play guitar while reading the score and with tuxguitar playing in the background. Some scores have large part while I am not playing and I use to recenter the score during these phases.

guiv42 commented 2 months ago

OK, understood. Sorry if the removal of scrollbars makes it more complicated for you, I could not find any better solution to this perf issue.

Does it mean we should create another action (and associated keyboard shortcut) to scroll up/down ?

guiv42 commented 1 month ago

I just restored the scrollbar(s), with an alternative fix for perf issue #403, see #557. Issue can be closed.

ycollet commented 1 month ago

Thanks a lot !