helgeerbe / picframe

Picture frame viewer for raspi, controlled via mqtt and automatticly integrated as mqtt device in homeassistant.
MIT License
95 stars 28 forks source link

Add improved support for auto-matting on non-HD resolutions #28

Closed jgodfrey closed 2 weeks ago

jgodfrey commented 3 years ago

Currently, the auto-matting capabilities of PictureFrame have been designed for HD resolutions. While the matting will work for non-HD resolutions, it won't look exactly as intended. For example, on a 4k display, the matting decorations (bevels, shadows, ...) will be narrower than intended.

The fix here will involve a number of things, including:

jgodfrey commented 3 years ago

Has anyone viewed the auto-mat results on a 4K display? While I can imagine what they look like (generally, too narrow I assume), I've actually never seen them. I do have a 4K TV I could hook up to I guess - it's just not in a convenient location for dev work...

jgodfrey commented 3 years ago

Still curious here - has anyone tried the matting on a 4k display? As described above, I can imagine what it'll look like, but I've yet to see it.

paddywwoof commented 3 years ago

I too don't have a 4k screen.. but you might be able to specify the dimensions in the config file wider than the screen. I will try that out now on the RPi4

PS yes it seems to work. Obviously you only see one corner of the 4k display... but you can imagine what it would look like. The paper scale looks big, presumably the dpi is higher on a 4k display than my old monitor.

Also it run very slowly. I've not attempted to measure it but it looks similar to the normal sized monitor with the non-hardware GL driver. i.e. 6 or 7 fps. I have had reports of slow running on large screens - not sure what to do about that. I will investigate further.

jgodfrey commented 3 years ago

I do have a 4k tv I could hook up to. So far, I've just been too lazy to do it... :)