helium / blockchain-core

Apache License 2.0
214 stars 85 forks source link

Fix unclosed rocks iterators #1397

Closed xandkar closed 2 years ago

evanmcc commented 2 years ago

suspect that the catch logging is going to be noisy, we might want to add a version of the macro that allows us not to log.

in any case, we want to log at warning, since error writes to the error log with fsync

xandkar commented 2 years ago

suspect that the catch logging is going to be noisy, we might want to add a version of the macro that allows us not to log.

added the an app env var to disable the logging.

in any case, we want to log at warning

switched it to warning.

since error writes to the error log with fsync

TIL!