helium / blockchain-core

Apache License 2.0
214 stars 85 forks source link

Fix h3dex GC during snapshot load #1420

Closed PaulVMo closed 2 years ago

PaulVMo commented 2 years ago

This change fixes an issue that nodes are seeing with periodic invalid transactions after loading a snapshot that was created following the h3dex / targeting v6 activation. While loading blocks as part of a snapshot, garbage collection is not being called called on the h3dex. Typically, GC occurs on the h3dex with each block. The change adds the missing maybe_gc_h3dex call following block absorb for each block loaded from the snapshot.

Thanks to @mawdegroot and @BigEnigma for working through the issue on the Discord #validator-ops channel.