helium / blockchain-core

Apache License 2.0
214 stars 85 forks source link

off-by-one error in blockchain_txn_consensus_group_failure_v1 #1421

Open Vagabond opened 2 years ago

Vagabond commented 2 years ago

The ledger_at in the validate function doesn't check that the block height needed is within the 50 block window of the lagging ledger, so sometimes a 51 block back txn can clear but be unabsorbable for nodes that GC'd the older ledger.