hellt / vrnetlab

Make VM-based Network OSes run in Containerlab
https://containerlab.dev
MIT License
129 stars 88 forks source link

Fix makefile-install.include naming schema #283

Closed kaelemc closed 4 days ago

kaelemc commented 4 days ago

At some point we changed to registry/vendor_platform:version naming scheme.

makefile-install.include wasn't updated to reflect this, which broke xrv9k (and maybe other platforms) which depend on this file for the install process as of current.

This PR simply changes the naming scheme (and variable names) in makefile-install.include to match the new naming scheme.

Tested with XRv9k to confirm it works.

hellt commented 4 days ago

thanks @kaelemc good catch, I did change it originally, but not consistently =(