search

hemilabs / heminetwork

The hemi network core daemons.
MIT License
73 stars 49 forks source link

Cli PoP miner shows incorrect version on startup #253

Closed Leonardiae closed 2 months ago

Leonardiae commented 2 months ago

Confirmation

Describe the bug

After starting the PoP cli miner, the first line on the console shows the version. The build is correct, but the version shows as v0.3.0 while this is v0.4.0.

2024-09-11 06:49:19 INFO popmd popmd.go:111 Hemi Proof-of-Proof Miner v0.3.0+6b218099f (Hemi Labs, popmd, go1.22.6 linux/amd64)

Expected behaviour

Show correct current version.

Environment

Version: Operating System: Architecture:

Additional Information

No response

jcvernaleo commented 2 months ago

@Leonardiae Could you confirm which build you downloaded? I just tried:

heminetwork_v0.4.0_linux_amd64.tar.gz

And I see this output which looks correct to me:

jcv@triforce heminetwork_v0.4.0_linux_amd64 $ ./popmd 
2024-09-11 13:03:18 INFO popmd popmd.go:111 Hemi Proof-of-Proof Miner v0.4.0+b66219584 (Hemi Labs, popmd, go1.23.1 linux/amd64)

Or did you build from source?

Leonardiae commented 2 months ago

Hmm that's strange. I downloaded the binaries and did not build it myself. I also downloaded heminetwork_v0.4.0_linux_amd64.tar.gz

I downloaded and installed most versions and non was showing the correct version. First I thought maybe it does not show minor version updates or something.

As you can see the build number is matching, it's just the version which is incorrect.

jcvernaleo commented 2 months ago

Okay, I do see that commit 6b21809 is for v0.3.2 and not v0.3.0. Which tarball was that one from?

Leonardiae commented 2 months ago

Oh wow, you are right, I'm running a different build than I thought. My apologies for not paying attention.

I downloaded and exstracted to current directory, but since 0.3.2 the files are in a subdirectory in the linux amd64 file apparently. My bad.

jcvernaleo commented 2 months ago

No worries, happy to have helped you figure it out!