search

henkelmax / easy-villagers

Never get annoyed by villagers again!
59 stars 26 forks source link

[1.21] Crash when rendering trader block tooltip #219

Closed JaisDK closed 4 months ago

JaisDK commented 4 months ago

Bug description

The trader block creates a VillagerTileentity with a null level which in turn creates a EasyVillagerEntity again with a null level. Level is not nullable on LivingEntity and it makes other mods crash.

Minecraft version

1.21

Mod version

1.21-1.1.15

Mod loader and version

NeoForge: 21.0.98-beta

Steps to reproduce

Install AE2, Adorned (or another curios port) and Easy Villagers put a trader block into the ae2 system and search

Expected behavior

No response

Log files

https://mclo.gs/zRv2ZEb

Screenshots

No response

henkelmax commented 4 months ago

I am not able to reproduce this without curios. I'm pretty sure its an issue with them, as their mixins cause the crash.

JaisDK commented 4 months ago

I know, that's what I said it makes other mods crash in this case Adorned because you create a LivingEntity without a level and Adorned has an event handler for when entities are created that checks if the level is client side. The error is in your mod as level is not nullable on LivingEntity.

henkelmax commented 4 months ago

image I just checked it again and it does not seem to happen with https://modrinth.com/mod/curios-continuation

henkelmax commented 4 months ago

I just checked again and it also doesn't seem to be happening with https://www.curseforge.com/minecraft/mc-mods/adorned aswell in the latest NeoForge version. image

JaisDK commented 4 months ago

It doesn't happen with adorned anymore because I put in a null check