search

henryboldi / felony

🔑🔥📈 Next Level PGP
MIT License
3.47k stars 130 forks source link

"Write a Message" pane gets stuck open #65

Closed jfrederickson closed 8 years ago

jfrederickson commented 8 years ago

I just had this happen after clicking on my two buddy entries a few times:

screen shot 2016-07-12 at 1 07 14 pm

jfrederickson commented 8 years ago

Looks like this happens when rapidly clicking on a buddy in the list.

greg-js commented 8 years ago

Confirmed.

I did a little testing, and it seems to happen when the animation for bringing up the opener in lines 48-55 of ./app/components/keychain/KeyChainComposerOpener.js has not yet completed by the time the user deselects the last selected buddy.

If the animation duration is set to 1, the problem disappears, but obviously then the animation disappears too. I couldn't immediately find the code that removes the opener when no buddies are selected, but I'm guessing it should be a relatively easy fix once one does. I might look into it later tonight if no one else has by then.

greg-js commented 8 years ago

Just submitted PR #66 with a fix (just to let you know since the reference isn't popping up here)