search

henryboldi / felony

🔑🔥📈 Next Level PGP
MIT License
3.47k stars 130 forks source link

Verifying a signed message #88

Open Fastidious opened 8 years ago

Fastidious commented 8 years ago

What's this issue about?

Verifying a self signed message wrong strings.

Expected behavior

Show the name/email of the person that signed the message.

Actual behavior

Show undefined .

Steps to reproduce

Create key, sign a message, verify it.

Environment

macOS Sierra.

screen shot 2016-10-24 at 9 55 53 am

frankcash commented 8 years ago

was the user part of your "Friends" list?

Fastidious commented 8 years ago

I was the user. I signed a message, and I verified it. That screenshot is the verification part.

frankcash commented 8 years ago

Yes , we need to account for this. I know if you add yourself it will work. If you'd like to submit a PR to fix this that would be great!

On Tue, Oct 25, 2016, 8:47 PM Fastidious notifications@github.com wrote:

I was the user. I signed a message, and I verified. That screenshot is the verification part.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/henryboldi/felony/issues/88#issuecomment-256220029, or mute the thread https://github.com/notifications/unsubscribe-auth/AFu9R9R6Ru5DHZx2fcCIOQSHchPbSGekks5q3qM2gaJpZM4Ke0cj .

Fastidious commented 8 years ago

@frankcash if I knew, I would have submitted one to begin with. :-)

ldabiralai commented 7 years ago

I just tried to reproduce this following the steps above and it seemed to work so we should close this, unless someone else can verify it as not working

Fastidious commented 7 years ago

@ldabiralai "it seemed to work?" This either works, or doesn't. This is still an issue. When someone produces a PR to account for this, that someone will close the issue.

ldabiralai commented 7 years ago

@Fastidious I said it seemed to work because I'm not that well versed in the expected behaviour.

I followed the steps you described above and received this message:

image

I added my own public key to my contact list and then received this:

image

To me, both of these behaviours look correct..

Fastidious commented 7 years ago

@ldabiralai I should not need to be on the contact list to sign a message. Why will I need to be on my contact list? That is exactly what needs to be accounted for, which @frankcash noted on his comment.

meMuszr commented 7 years ago

Working on this if that's okay ~

meMuszr commented 7 years ago

npm-debug.log Unfortunately couldn't even get this to run.. :\