search

herbie-fp / herbie

Optimize floating-point expressions for accuracy
https://herbie.uwplse.org
Other
770 stars 33 forks source link

Local Error tree request crash from Odyessy. #1040

Closed zaneenders closed 8 hours ago

zaneenders commented 1 day ago

Herbie: 9287265 Odyssey: 8da4444

Local error Job local-error started:
  6683211e2a23c4513fc9e4f674244d1c4489c204 (if (<= (exp b) 0.8) 0.5 (pow (fma (fma (fma 0.16666666666666666 b 0.5) b 1.0) b 2.0) (- 1.0)))...
first: contract violation
  expected: (and/c list? (not/c empty?))
  given: '#s(literal 1/2 binary64)
  context...:
   /Users/zane/.scribe/Projects/herbie/src/core/localize.rkt:214:0: local-error-as-tree
   /Users/zane/.scribe/Projects/herbie/src/api/sandbox.rkt:282:6
   /Applications/Racket v8.14/collects/racket/engine.rkt:42:24
elmisback commented 1 day ago

What was the expression submitted for this?

pavpanchekha commented 1 day ago

I bet it's fixed by #1043 though it's worth re-testing.

zaneenders commented 8 hours ago

@elmisback The expression was:

(FPCore (a b)
 :name "Quotient of sum of exps"
 :alt 
 (! :herbie-platform default
  (/ 1 (+ 1 (exp (- b a)))))

 (/ (exp a) (+ (exp a) (exp b))))

@pavpanchekha is correct this #1043 did fix this issue, closing now.