heronarts / LX

Core library for 3D LED lighting engines
https://chromatik.co/
Other
41 stars 25 forks source link

Prevent washout accumulation in BlurEffect #114

Closed jkbelcher closed 3 weeks ago

jkbelcher commented 4 weeks ago

Have felt in the past like BlurEffect too easily turned into white. I think this was the culprit.

To reproduce:

I'm thinking the intention is for new colors to have an "overwrite" effect e.g. max(blurBuffer, new) but not an additive effect. If the pattern jumped around between colors this was easily creating white. Seems better now in local testing.

Added a return when disabled to save the math overhead, since the blurBuffer is reset when re-enabled.