Enum value SgfcMessageID::IllegalVariationStartCorrected has wrong numeric value

herzbube / libsgfcplusplus

libsgfc++. A C++ library that uses SGFC to read and write SGF (Smart Game Format) data.

Apache License 2.0

12 stars 2 forks source link

Enum value SgfcMessageID::IllegalVariationStartCorrected has wrong numeric value #39

Closed herzbube closed 11 months ago

herzbube commented 11 months ago

The enum value SgfcMessageID::IllegalVariationStartCorrected has the wrong numeric value 21, effectively creating a duplicate of SgfcMessageID::IllegalVariationStartIgnored.

The correct value is 67.

herzbube commented 11 months ago

With limited effort I have been unable to find out whether changing the underlying numeric value of an enum value ...

... is an ABI breaking change
... or, if it is not an ABI breaking change, whether a library client needs to be recompiled to use the new numeric value

To be on the safe side, the fix will be shipped with a release that has a new major version number.