search

hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
740 stars 118 forks source link

chore: skaffold was not using the built image #685

Closed apricote closed 4 months ago

apricote commented 4 months ago

We changed the image reference in a recent PR. With this, skaffold was unable to match it against the image referenced in the Helm chart, so it always deployed the tagged version of the image.

This caused all e2e tests to not use the actual changes made in those PRs.

Noticed this because the release-please PR was trying to pull a v1.20.0 image and failed.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.26%. Comparing base (efa5585) to head (d8463be).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #685 +/- ## ======================================= Coverage 72.26% 72.26% ======================================= Files 32 32 Lines 2668 2668 ======================================= Hits 1928 1928 Misses 552 552 Partials 188 188 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jooola commented 4 months ago

Should we also update on the csi-driver side https://github.com/hetznercloud/csi-driver/blob/main/skaffold.yaml#L7 ?

apricote commented 4 months ago

csi-driver should be fine, it references the images with that prefix in the Helm Chart: https://github.com/hetznercloud/csi-driver/blob/4c77198f9138dfc672cedea184551de2c20857b0/chart/values.yaml#L131