search

hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
740 stars 118 forks source link

Implement support for custom internal IP mapping via HCLOUD_INSTANCES… #696

Open elohmeier opened 4 months ago

elohmeier commented 4 months ago

This update adds the ability to specify custom internal IP addresses for Hetzner Cloud and Robot Instances through the HCLOUD_INSTANCES_INTERNAL_IP_MAP environment variable.

This is especially useful when mixing cloud servers with dedicated robot servers via vSwitch / private networks. Users will need to manage the IPs of the robot servers manually anyway, this change let users specify them as well for the InternalIp field in K8S.

apricote commented 4 months ago

Hey @elohmeier, thanks for the PR! Our team is a little bit short on time right now with vacations, so the review is going to take some more weeks. I am sorry for this.

elohmeier commented 4 months ago

Thanks for you message, no problem. I wonder if there is upstream interest for this addition? If so, please let me know - I would then take a look into the CI issues and rebase.

github-actions[bot] commented 1 month ago

This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs.

elohmeier commented 3 weeks ago

Rebased onto latest main branch.

pat-s commented 1 week ago

@elohmeier Can you add a usage example for how to specify the mapping? Tried your PR but neither got the IP added nor an error in hccm. Specified it as

          HCLOUD_INSTANCES_INTERNAL_IP_MAP:
            nodename: 'nodeip'