hetznercloud / hcloud-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud
Apache License 2.0
703 stars 112 forks source link

Properly set IP Mode of Load Balancer Addresses to fix internal PROXY traffic #727

Open apricote opened 3 weeks ago

apricote commented 3 weeks ago

TL;DR

KEP-1860 introduced a new field service.status.loadBalancer.ingress[].ipMode: VIP | Proxy to indicate the behavior of the Load Balancer.

Currently users on IPVS-based networking setups can not access the Load Balancer IPs when they enable PROXY protocol.

Expected behavior

Users should always be able to access their services from inside of the cluster, even if they use IPVS and PROXY protocol.

IIUC we should set the IP Mode to Proxy for the IPs we return in the status.

BartVB commented 2 weeks ago

Would be fantastic if this could be implemented!

I have been banging my head against the wall for quite a bit of time when running into this issue. It results in rather strange/unexpected behaviour in the cluster. Would be a BIG help if this status field could be added to prevent others from wasting time when trying to trace this issue.

Related article with someone else running into this: https://www.bitahoy.com/blog/post/how-kubernetes-violates-the-principle-of-least-surprise-when-used-with-proxy-protocol-on-hetzner-load-balancers