search

hexdigest / gowrap

GoWrap is a command line tool for generating decorators for Go interfaces
MIT License
1.06k stars 82 forks source link

Feature Generics #60

Closed NoGambiNoBugs closed 1 year ago

NoGambiNoBugs commented 1 year ago

Hi, This is a feature for support generics, the changes is in generator, for now is just to analyze and test, I was removed two unit tests and create a new file, so I still need to create the unit tests and I will do it this, but until then can be reviewed.

NoGambiNoBugs commented 1 year ago

@hexdigest the unit tests already is working, but i'll complement to not decrease the coverage.

NoGambiNoBugs commented 1 year ago

@hexdigest the CI is broked because the ast.IndexListExp, this was introduced on go1.18, I never working with goreleaser, is necessary change something in goreleaser or just set a version in go.mod?

hexdigest commented 1 year ago

@hexdigest the CI is broked because the ast.IndexListExp, this was introduced on go1.18, I never working with goreleaser, is necessary change something in goreleaser or just set a version in go.mod?

Please merge the master branch, I just updated go & golangci-lint versions for CI.

NoGambiNoBugs commented 1 year ago

@hexdigest the coverage was improved with unit tests, also I create examples to check the result with N cases of interfaces with generics, is available here. I believe that all is working, but I recommend that you test also.

hexdigest commented 1 year ago

Thanks for this great PR @NoGambiNoBugs !

It's available in v1.3.0