chore(deps-dev): Limited `@types/node` version

hexojs / hexo

A fast, simple & powerful blog framework, powered by Node.js.

https://hexo.io

MIT License

38.83k stars 4.75k forks source link

chore(deps-dev): Limited `@types/node` version #5411

Closed uiolee closed 5 months ago

uiolee commented 5 months ago

What does it do?

Temporarily fix #5408

Screenshots

Pull request tasks

[ ] Add test cases for the changes.
[ ] Passed the CI test.

github-actions[bot] commented 5 months ago

How to test

git clone -b fix/type/node/version https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 7684357654

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.53%

Totals
Change from base Build 7621654375:	0.0%
Covered Lines:	9312
Relevant Lines:	9356

💛 - Coveralls

uiolee commented 5 months ago

Yes. But several of our packages use the newer types.

However that's not the point. In fact, the old version of types was wrong, and the new version of type fixes the past mistakes. I guess this PR is just a temporary fix.