hey24sheep / azure-flutter-tasks

Easily build and deploy with latest Flutter build tasks for Azure DevOps Pipelines Tasks
https://marketplace.visualstudio.com/items?itemName=Hey24sheep.flutter
MIT License
89 stars 22 forks source link

If flavour is specified, it must be passed through to the flutter build command #103

Open guulp opened 12 months ago

guulp commented 12 months ago

The flavour is necessary whether or not this is a simulator build or not. This line should be removed. If your build configuration settings use flavours then you always need to specify them:

https://github.com/hey24sheep/azure-flutter-tasks/blob/92e259d8763420579341240ecf29e60c22d5d8a0/tasks/build/index.ts#L430

hey24sheep commented 11 months ago

That might be the part of the new Flutter build, on older versions of Flutter it was not the case. But, we can remove the simulator check and have it add build flavor if it is given by the user.

I'll need sometime to work on it as I am quite busy.

guulp commented 11 months ago

Sure, and thanks for creating this task to begin with.

My current workaround is:

  - task: Hey24sheep.flutter.flutter-build.FlutterBuild@0
    displayName: 'Build ${{parameters.flavour}}'
    inputs:
      buildFlavour: '${{parameters.flavour}}'
      verboseMode: true
......
      extraArgs: '--simulator'