search

hey24sheep / azure-flutter-tasks

Easily build and deploy with latest Flutter build tasks for Azure DevOps Pipelines Tasks
https://marketplace.visualstudio.com/items?itemName=Hey24sheep.flutter
MIT License
89 stars 22 forks source link

dartDefineMulti doesnt seem to be working anymore #94

Closed ManishKiranagi closed 1 year ago

ManishKiranagi commented 1 year ago

It is adding --dart-define for the entire string only once, instead of adding --dart-define for each of the space separated variables This was working fine on Friday

DaveBubenik commented 1 year ago

I'm seeing the same issue, I added "--dart-define=" in front of additional defines as a temporary work around.

hey24sheep commented 1 year ago

Hi, I will try to push a fix after work. Thank you for reporting.

ManishKiranagi commented 1 year ago

I'm seeing the same issue, I added "--dart-define=" in front of additional defines as a temporary work around.

I tried that, but doesnt work for me... This is what I did dartDefineMulti: "A=AVAL --dart-define=B=BVAL"

frederikstonge commented 1 year ago

Everything seems to be broken. I get a "Target file not found".

It was working fine on friday on version 0.3.6, but since 0.3.7, everything after flutter build <platform> doesn't work and act as a target file.

frederikstonge commented 1 year ago

Latest version

Starting: Flutter Build
==============================================================================
Task         : Flutter Build Task
Description  : Build a Flutter application project.
Version      : 0.3.7
Author       : Hey24sheep
Help         : [More Information](https://github.com/hey24sheep/azure-flutter-tasks)
==============================================================================
/Users/runner/hostedtoolcache/Flutter/3.10.6/macos/flutter/bin/flutter build ipa --release --build-number=247594 --export-options-plist /Users/runner/export_options.plist --dart-define-from-file=config/VanillaDev.json
Target file "--release --build-number=247594 --export-options-plist /Users/runner/export_options.plist --dart-define-from-file=config/VanillaDev.json" not found.
##[error]Error: The process '/Users/runner/hostedtoolcache/Flutter/3.10.6/macos/flutter/bin/flutter' failed with exit code 1
Finishing: Flutter Build

Previous version

Starting: Flutter Build
==============================================================================
Task         : Flutter Build Task
Description  : Build a Flutter application project.
Version      : 0.3.6
Author       : Hey24sheep
Help         : [More Information](https://github.com/hey24sheep/azure-flutter-tasks)
==============================================================================
/Users/runner/hostedtoolcache/Flutter/3.10.6/macos/flutter/bin/flutter build ipa --release --build-number=247230 --export-options-plist /Users/runner/export_options.plist --dart-define-from-file=config/VanillaDev.json
hey24sheep commented 1 year ago

Hi all, I have updated the extension to 0.3.14 it introduces a new separator input param to fix the multiple arguments or multiple dart defines (containing whitespace within values). Please check the readme & changelogs for further details.

Builds must be fixed now, please let me know by closing your respective issues, thank you all.

ManishKiranagi commented 1 year ago

@hey24sheep dartDefineMulti is now working as previously for me. Thanks