Closed lsmith77 closed 5 years ago
thx for the feedback!
@hfaran anything else to fix?
@lsmith77 one final thing before I merge this - can you please add a couple screenshots of the UI to demonstrate an example without these options turned on and one with the options? Thanks!
here is link to a rendered output https://symfony.github.io/diversity/diversity-meetings-2019-01-03.html
or do you prefer a screenshot?
added a screenshot
I think this broke the "single-file export" CLI command added in https://github.com/hfaran/slack-export-viewer/pull/79
Traceback (most recent call last):
File "/Users/rmacklin/.pyenv/versions/2.7.13/bin/slack-export-viewer-cli", line 11, in <module>
load_entry_point('slack-export-viewer==0.9.0', 'console_scripts', 'slack-export-viewer-cli')()
File "/Users/rmacklin/.pyenv/versions/2.7.13/lib/python2.7/site-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/Users/rmacklin/.pyenv/versions/2.7.13/lib/python2.7/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/Users/rmacklin/.pyenv/versions/2.7.13/lib/python2.7/site-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/rmacklin/.pyenv/versions/2.7.13/lib/python2.7/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/rmacklin/.pyenv/versions/2.7.13/lib/python2.7/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/Users/rmacklin/.pyenv/versions/2.7.13/lib/python2.7/site-packages/slackviewer/cli.py", line 43, in export
[{"channel_name": k, "messages": v} for (k,v) in r.compile_channels().iteritems()],
TypeError: compile_channels() takes exactly 2 arguments (1 given)
@rmacklin I just fixed this and published 0.9.5. Please let me know if that works.
Thanks, it works in 0.9.5
👍
still very much a python n00b but trying my best :)
fixes https://github.com/hfaran/slack-export-viewer/issues/90
these options allow me to generate logs like the following: https://github.com/symfony/diversity/commit/df8e324e757d1446ab6f242d8dbba85d7dfe3163
you can see the real life html here: https://symfony.github.io/diversity/diversity-meetings-2019-01-03.html
a small screenshot here: