hhoffstaette / kernel-patches

Custom Linux kernel patches
39 stars 7 forks source link

Error in "vfs-20200512-keep-inodes-with-page-cache-off-the-inode-shrinker-LRU.patch" #15

Closed torvic9 closed 4 years ago

torvic9 commented 4 years ago

Third hunk should be inode_pages_clear(mapping->host) and inode_pages_set(mapping->host)

instead of mapping->inode.

Else it throws an error if DAX is enabled:

fs/dax.c:556:30: error: no member named 'inode' in 'struct address_space'
                inode_pages_clear(mapping->inode);
                                  ~~~~~~~  ^
fs/dax.c:558:28: error: no member named 'inode' in 'struct address_space'
                inode_pages_set(mapping->inode);

(tested with clang-10)

hhoffstaette commented 4 years ago

Sorry for the delay, it seems Github's changes to notifications no longer send emails for issues. I'll look into the change immediately.

hhoffstaette commented 4 years ago

You're completely right - good catch. I don't use DAX and therefore didn't catch it either.

hhoffstaette commented 4 years ago

Merged, thanks!