Fix boost compilation - this enforces correct c++ library

[viatsko]

Should fix #17

[viatsko]

Hmmm, so suggestion is to remove :build? I think that people who have boost built with gcc are not getting it from bottles as by default boost is fitting for hhvm

[denji]

:build to install boost for building of source code (only), but these libraries always need hhvm. Apple does not provide boost-libs.

[viatsko]

So it should be

depends_on "boost" => "c++11"

if I understand the Brew syntax correctly?

And same thing should be done to llvm?

[denji]

In square [single element | brackets to denote] an array / use a string representation.

In any case, equally well:

depends_on "llvm" => ["with-clang", "with-libcxx"]
depends_on "boost" => "c++11"

depends_on "llvm" => ["with-clang", "with-libcxx"]
depends_on "boost" => ["c++11"]

[viatsko]

Okay, thank you for your tips, Denis! I owe you beer if you'll be in Amsterdam :+1:

I fixed this PR and created a separate PR for llvm.

[jwatzman]

Can you point me at the brew docs where it says what the c++11 modifier means? It's unclear to me that it means "must build with llvm", which is what we require here.

[denji]

@jwatzman It's unclear to me that it means "must build with llvm", which is what we require here.

otool -L $(which hhvm)
ldd $(which hhvm)

[fredemmott]

Moot: https://github.com/hhvm/homebrew-hhvm/commit/e69dd242cf63337794addb82f9bcc7a3bf3aa351