beatscode commented 7 years ago

Description

After installing hhvm I can't successfully run hh_client. The log mentions of a different version of the server but I have not launched a server at all. I currently run my application in docker(docker for mac) but I'd like to use local hh_client for IDE support.

Server launched with the following command:
    '/usr/local/Cellar/hhvm/HEAD-a7c4921/bin/hh_server' '-d' '/Users/alex/projects/leonardo2' '--waiting-client' '7'
Spawned typechecker (child pid=27189)
Logs will go to /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.monitor_log
hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
Hack: hh_client output error: SyntaxError: Unexpected token F in JSON at position 0
Hack: hh_client execution error: Error: Command failed: /usr/local/Cellar/hhvm/HEAD-a7c4921/bin/hh_client --format 0 44014 --json /Users/alex/projects/leonardo2
hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
Hack: hh_client output error: SyntaxError: Unexpected token h in JSON at position 0
Hack: hh_client execution error: Error: Command failed: /usr/local/Cellar/hhvm/HEAD-a7c4921/bin/hh_client --type-at-pos /Users/alex/projects/leonardo2/application/controllers/start.php:9:41 --json /Users/alex/projects/leonardo2
hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
Hack: hh_client output error: SyntaxError: Unexpected token h in JSON at position 0
Hack: hh_client execution error: Error: Command failed: /usr/local/Cellar/hhvm/HEAD-a7c4921/bin/hh_client --ide-get-definition 9:46 --json /Users/alex/projects/leonardo2
hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
Hack: hh_client output error: SyntaxError: Unexpected token h in JSON at position 0
Hack: hh_client execution error: Error: Command failed: /usr/local/Cellar/hhvm/HEAD-a7c4921/bin/hh_client --type-at-pos /Users/alex/projects/leonardo2/application/controllers/start.php:9:41 --json /Users/alex/projects/leonardo2
hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
Hack: hh_client output error: SyntaxError: Unexpected token h in JSON at position 0

Context and Logs

Parameter	Value
OS X Version:	10.12.5
Homebrew Version:	1.2.3
Xcode Version:	8.2.1

Output of clang -v: Apple LLVM version 8.0.0 (clang-800.0.42.1) Target: x86_64-apple-darwin16.6.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Build logs: https://gist.github.com/89f3f7e7e7a0d25de1db0d673caad3e2

mofarrell commented 7 years ago

I take it this runs cleanly in the container? Perhaps try running hh_client on a test hack project to see if it works for that. (1 simple file and a .hhconfig) I am unable to reproduce the issue using our docker build for 3.20.2 running hh_client on our docs site (https://github.com/hhvm/user-documentation).

jwatzman commented 7 years ago

Also hh_server is dying, I'd be curious what the output of '/usr/local/Cellar/hhvm/HEAD-a7c4921/bin/hh_server' '-d' '/Users/alex/projects/leonardo2' is.

beatscode commented 7 years ago

I ran @jwatzman suggestion and received the following.

➜  leonardo2 git:(hhvm) ✗ /usr/local/bin/hh_server -d /Users/alex/projects/leonardo2
Spawned typechecker (child pid=2329)
Logs will go to /private/tmp/hh_server/monitor_logs/zSUserszSalexzSprojectszSleonardo2-2017-06-19-12-02-36.monitor_log
➜  leonardo2 git:(hhvm) ✗ cat /private/tmp/hh_server/monitor_logs/zSUserszSalexzSprojectszSleonardo2-2017-06-19-12-02-36.monitor_log
/etc/hh.conf:
; php options
;
session.save_handler = files
session.save_path = /var/lib/php5
session.gc_maxlifetime = 1440

; hhvm specific
;hhvm.jit_warmup_requests = 10

hhvm.server.port=9000
hhvm.server.type=server
hhvm.server.source_root=/Users/alex/projects/leonardo2
hhvm.server.default_document = index.php

hhvm.log.use_log_file = true
hhvm.log.level = Verbose
hhvm.log.file = /var/log/hhvm/error.log
hhvm.log.header = true
hhvm.log.use_sys_log = true
hhvm.log.injected_stack_trace = true
hhvm.log.native_stack_trace = true
hhvm.log.always_log_unhandled_exceptions = true
hhvm.log.runtime_error_reporting_level = 1
hhvm.mysql.typed_results = false

;hhvm.hack.lang.look_for_typechecker = false
hhvm.utf8 = true

[2017-06-19 12:02:36] Loading config exception: Failure("failed to parse config")
[2017-06-19 12:02:36] Could not load config at /etc/hh.conf, using defaults
[2017-06-19 12:02:36] Starting first server
[2017-06-19 12:02:36] About to spawn typechecker daemon. Logs will go to /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.log

[2017-06-19 12:02:36] Just started typechecker server with pid: 2342.
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
[2017-06-19 12:02:39] check_and_run_loop_ threw with exception: File "utils/sys_utils.ml", line 121, characters 2-8: Assertion failed
[2017-06-19 12:02:40] check_and_run_loop_ threw with Unix.ECHILD. Exiting

I then ran @mofarrell suggestion. Created a test.php and .hhconfig file in a new directory.

➜  hacktest cat test.php
<?hh

function foo(int $a, int $b): int{
    return "";
}

foo();
➜  hacktest hh_client
test.php:4:9,10: Invalid return type (Typing[4110])
  test.php:3:31,33: This is an int
  test.php:4:9,10: It is incompatible with a string

mofarrell commented 7 years ago

If you run it as root it should be able to get past that error. Essentially if a worker process crashes the monitoring process tries to check the dmesg output to see if it was an OOM. dmesg is not privileged on most linux systems, but is on OS X. You might see another error, or perhaps it will manage to relaunch worker processes, and finish typechecking. My guess is it will work if it is being killed because of an OOM.

beatscode commented 7 years ago

I ran sudo -s then ran hh_server again

➜  leonardo2 git:(hhvm) ✗ cat /private/tmp/hh_server/monitor_logs/zSUserszSalexzSprojectszSleonardo2-2017-06-19-13-50-31.monitor_log
/etc/hh.conf:
; php options
;
session.save_handler = files
session.save_path = /var/lib/php5
session.gc_maxlifetime = 1440

; hhvm specific
;hhvm.jit_warmup_requests = 10

hhvm.server.port=9000
hhvm.server.type=server
hhvm.server.source_root=/Users/alex/projects/leonardo2
hhvm.server.default_document = index.php

hhvm.log.use_log_file = true
hhvm.log.level = Verbose
hhvm.log.file = /var/log/hhvm/error.log
hhvm.log.header = true
hhvm.log.use_sys_log = true
hhvm.log.injected_stack_trace = true
hhvm.log.native_stack_trace = true
hhvm.log.always_log_unhandled_exceptions = true
hhvm.log.runtime_error_reporting_level = 1
hhvm.mysql.typed_results = false

;hhvm.hack.lang.look_for_typechecker = false
hhvm.utf8 = true

[2017-06-19 13:50:31] Loading config exception: Failure("failed to parse config")
[2017-06-19 13:50:31] Could not load config at /etc/hh.conf, using defaults
[2017-06-19 13:50:31] Starting first server
[2017-06-19 13:50:31] About to spawn typechecker daemon. Logs will go to /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.log

[2017-06-19 13:50:31] Just started typechecker server with pid: 7382.
[2017-06-19 13:50:34] Unexpected output of command 'grep -m 1 Lazy_check /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.log | wc -l':        0
[2017-06-19 13:50:34] typechecker exit with exit code 16

mofarrell commented 7 years ago

https://github.com/facebook/hhvm/blob/7625626aa476421ff9c2aca91af8ea3fe4e16102/hphp/hack/src/utils/exit_status.ml#L101 Just a thought, the sharedmem_hash_table_pow and sharedmem_dep_table_pow settings may help. The defaults are:

sharedmem_dep_table_pow = 17
sharedmem_hash_table_pow = 18

The size ends up being 1 << by those values. So those are less than 256kb. I don't know how big your project is, but this could be impacting it. Although I would be surprised if it didn't impact it on linux as well.

It is probably worth noting that you have your hhvm settings (i.e. ini settings) in your hh.conf file. I would definitely fix that.

beatscode commented 7 years ago

Thanks @mofarrell, could you clarify the meaning of 1 << by those values? I'm not sure what made me put the content I currently have in hh.conf. Are the correct properties from this page? https://docs.hhvm.com/hack/typechecker/setup#configuration-settings

The directory size is 6Gb ( mostly project assets via symlinks). Is there a way to exclude directories?

mofarrell commented 7 years ago

I was thinking left shift by the value, or 2 to the power of the value. For example the default value for sharedmem_hash_table_pow is 18, and that would correspond to 2^18 = 1 << 18 = 256KB I am still unclear how much of those 6GB is code (hopefully not all), but the typechecker has to keep track of all the dependencies between files in your codebase so that it can properly perform incremental updates. This can take up a fair amount of room, but I would be surprised if your code base would use more than 10MB or so. Again this might be totally off, as I am just reading through some code here, and trying to guess what is happening.

beatscode commented 7 years ago

There's about 100MB of php code. Not all of it has been converted to <?hh files but the rest of the files in this directory are storage files(logs, sql, docs). I tried changing sharedmem_hash_table_pow and sharedmem_dep_table_pow to 31 2 << 31 = 2GB but no change in the logs it still dies with exit code 16. Not sure if the error is contingent on plain old file usage, php file usage, or files converted to hack. I removed about 4GB of assets to try again but still no cigar.

/etc/hh.conf:
sharedmem_dep_table_pow = 31
sharedmem_hash_table_pow = 31

[2017-06-22 17:24:33] Starting first server
[2017-06-22 17:24:33] About to spawn typechecker daemon. Logs will go to /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.log

[2017-06-22 17:24:33] Just started typechecker server with pid: 47366.
[2017-06-22 17:24:33] Got request for typechecker. Prior request 0.0 seconds ago
[2017-06-22 17:24:37] Unexpected output of command 'grep -m 1 Lazy_check /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.log | wc -l':        0
[2017-06-22 17:24:37] typechecker exit with exit code 16

I put the .hhconfig file in a smaller subdirectory and the client ran so its definitely an issue around the disk usage of the root directory. Is there anyway to help this?

fredemmott commented 7 years ago

What's in the log files? "Logs will go to" etc

beatscode commented 7 years ago

cat /private/tmp/hh_server/zSUserszSalexzSprojectszSleonardo2.log
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

[2017-06-23 11:49:36] Version: 056401960b1a5e7e2c5d4a2700d5f759d98ac0c1 Fri Jun 16 20:30:01 2017
[2017-06-23 11:49:36] Hostname: Alexs-MBP-127.fios-router.home
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

[2017-06-23 11:49:36] No debug port attached
[2017-06-23 11:49:36] Initializing Server (This might take some time)
[2017-06-23 11:49:36] Init id: qqHxV0XGMU
[2017-06-23 11:49:36] Indexing: 0.000010
[2017-06-23 11:49:37] Heap size: 3595456
[2017-06-23 11:49:37] Parsing: 1.194292
[2017-06-23 11:49:37] Updating deps: 0.010517
[2017-06-23 11:49:37] Heap size: 4479680
[2017-06-23 11:49:37] Naming: 0.019208
[2017-06-23 11:49:38] Heap size: 5948096
[2017-06-23 11:49:38] Type-check: 0.571088
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Subprocess(96421): fail 16[2017-06-23 11:49:38] Worker.Worker_exited_abnormally(16)
Raised at file "procs/worker.ml", line 315, characters 8-42
Called from file "procs/worker.ml", line 362, characters 18-29
Re-raised at file "procs/worker.ml", line 372, characters 8-17
Called from file "procs/multiWorker.ml", line 77, characters 31-52
Called from file "list.ml", line 88, characters 24-34
Called from file "third-party/core/core_list.ml" (inlined), line 192, characters 22-47
Called from file "procs/multiWorker.ml", line 76, characters 6-111
Called from file "procs/multiWorker.ml" (inlined), line 87, characters 20-70
Called from file "server/searchServiceRunner.ml", line 54, characters 8-180
Called from file "server/searchServiceRunner.ml" (inlined), line 70, characters 4-43
Called from file "server/serverInit.ml", line 710, characters 4-43
Called from file "server/serverInit.ml", line 753, characters 2-19
Called from file "server/serverMain.ml", line 444, characters 19-39
Called from file "stubs/hackEventLogger.ml" (inlined), line 83, characters 27-31
Called from file "server/serverMain.ml", line 36, characters 14-67
Called from file "server/serverMain.ml", line 537, characters 12-74
Called from file "server/serverUtils.ml", line 67, characters 6-10
Worker exited (code: 16)

beatscode commented 6 years ago

I tried hh_server again with the following on Mac Book Pro 2015 High Sierra. 10.13.2

HipHop VM 3.24.0-0brew (rel)
Compiler: 1516124398_N
Repo schema: bf846e54c28f516a4d4ad6d0913506e5ae49aa67

hh_server .
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

Informant using dummy - resigning
[2018-01-17 14:24:04] Starting first server
[2018-01-17 14:24:04] About to spawn typechecker daemon. Logs will go here.
[2018-01-17 14:24:04] Just started typechecker server with pid: 86830.
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

[2018-01-17 14:24:04] Version: hh-cf85042865a440b26ea1878b47b3e76ca316c37d-3.24.0 Tue Jan 16 12:40:03 2018
[2018-01-17 14:24:04] Hostname: Alexs-MBP-127.fios-router.home
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

[2018-01-17 14:24:04] No debug port attached
[2018-01-17 14:24:04] Initializing Server (This might take some time)
[2018-01-17 14:24:04] Init id: mi2zzo2k23
[2018-01-17 14:24:04] Indexing: 0.000008
[2018-01-17 14:24:04] Got request for typechecker. Prior request 0.0 seconds ago
[2018-01-17 14:24:06] Heap size: 21091264
[2018-01-17 14:24:06] Parsing: 1.949268
[2018-01-17 14:24:06] Updating deps: 0.023431
[2018-01-17 14:24:06] Heap size: 21999872
[2018-01-17 14:24:06] Naming: 0.035352
[2018-01-17 14:24:07] Heap size: 23680000
[2018-01-17 14:24:07] Type-check: 0.990610
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Subprocess(86833): fail 16[2018-01-17 14:24:07] Worker.Worker_exited_abnormally(16)
Raised at file "procs/worker.ml", line 341, characters 8-42
Called from file "procs/worker.ml", line 388, characters 18-29
Re-raised at file "procs/worker.ml", line 398, characters 8-17
Called from file "procs/multiWorker.ml", line 77, characters 31-52
Called from file "list.ml", line 96, characters 24-34
Called from file "third-party/core/core_list.ml" (inlined), line 192, characters 22-47
Called from file "procs/multiWorker.ml", line 76, characters 6-111
Called from file "procs/multiWorker.ml" (inlined), line 87, characters 20-70
Called from file "server/searchServiceRunner.ml", line 54, characters 8-180
Called from file "server/searchServiceRunner.ml" (inlined), line 70, characters 4-43
Called from file "server/serverInit.ml", line 1019, characters 4-43
Called from file "server/serverInit.ml", line 1089, characters 2-19
Called from file "server/serverMain.ml", line 438, characters 19-39
Called from file "stubs/hackEventLogger.ml" (inlined), line 91, characters 27-31
Called from file "server/serverMain.ml", line 36, characters 14-67
Called from file "server/serverMain.ml", line 554, characters 12-74
Called from file "server/serverUtils.ml", line 72, characters 6-10
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
[2018-01-17 14:24:08] check_and_run_loop_ threw with exception: File "utils/sys/sys_utils.ml", line 125, characters 2-8: Assertion failed
[2018-01-17 14:24:08] check_and_run_loop_ threw with Unix.ECHILD. Exiting

beatscode commented 6 years ago

I'm guessing this has to do with my workspace instead of hhvm. I installed ubuntu 17.10 on a different machine and I'm getting the following logs which are similar to previous logs on the mac. I added the same /etc/hh.conf config. Any suggestions on what configs to change?

alex-linuxbook% cat /etc/hh.conf 
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

alex-linuxbook% cd ~/projects/mednet/leonardo2
alex-linuxbook% hh_client 
Last server exited with code: 16.
For more detailed logs, try `tail -f $(hh_client --monitor-logname) $(hh_client --logname)`
Server launched with the following command:
    '/usr/bin/hh_server' '-d' '/home/alex/projects/mednet/leonardo2' '--waiting-client' '8'
Spawned typechecker (child pid=9133)
Logs will go to /tmp/hh_server/monitor_logs/zShomezSalexzSprojectszSmednetzSleonardo2-2018-01-30-10-44-39.monitor_log
hh_server is busy: [processing] -hh_server died unexpectedly. Maybe you recently launched aalex-linuxbookalexalex-alex-linuxbalex-alalalealex-lialexalalalexalalaaaalex-linuxbook% 
alex-linuxbook% tail -f $(hh_client --monitor-logname) $(hh_client --logname) 
==> /tmp/hh_server/zShomezSalexzSprojectszSmednetzSleonardo2.monitor_log <==
sharedmem_hash_table_pow = 32

[2018-01-30 10:44:39] Starting first server
[2018-01-30 10:44:39] About to spawn typechecker daemon. Logs will go to /tmp/hh_server/zShomezSalexzSprojectszSmednetzSleonardo2.log

[2018-01-30 10:44:39] Just started typechecker server with pid: 9138.
[2018-01-30 10:44:39] Got request for typechecker. Prior request 0.0 seconds ago
[2018-01-30 10:44:45] typechecker exit with exit code 16

==> /tmp/hh_server/zShomezSalexzSprojectszSmednetzSleonardo2.log <==
Called from file "server/searchServiceRunner.ml", line 54, characters 8-180
Called from file "server/searchServiceRunner.ml" (inlined), line 70, characters 4-43
Called from file "server/serverInit.ml", line 712, characters 4-43
Called from file "server/serverInit.ml", line 755, characters 2-19
Called from file "server/serverMain.ml", line 444, characters 19-39
Called from file "stubs/hackEventLogger.ml" (inlined), line 83, characters 27-31
Called from file "server/serverMain.ml", line 36, characters 14-67
Called from file "server/serverMain.ml", line 537, characters 12-74
Called from file "server/serverUtils.ml", line 67, characters 6-10
Worker exited (code: 16)

Disk Usage for base directory

alex-linuxbook% du -hs .
6.2G    .

HHVM Version

HipHop VM 3.21.0 (rel)
Compiler: 3.21.0+dfsg-2
Repo schema: 1c159cf2047dca5f4a3363b2138a33e14a1e99fa

fredemmott commented 6 years ago

For both platforms, are you able to reproduce with:

an empty directory, except for .hhconfig
any of our Hack github projects, e.g. https://github.com/hhvm/hsl/
no /etc/hh.conf

?

Can you also see what happens when you run hh_server --check $(pwd), instead of spawning the daemon

Mac

Are you using our bottles, or was this a source build?

We're looking into a bunch of issues around the IPC, though I've not seen that particular case, and it's usually working pretty OK; the only reproducible failure we're seeing is hh_client hanging if it's spawning the server or just started.

Ubuntu

Are you able to reproduce this with our packages, rather than Ubuntus ones? https://docs.hhvm.com/hhvm/installation/linux

this will rule out potential differences in build configuration (e.g. we pin to specific versions of some dependencies, including ocaml)
we're now on to 3.21.5, with 3.21.6 currently building; we're not tracking what they've added to dfsg-2, but given the numbers, they're definitely not tracking our fixes 1:1

beatscode commented 6 years ago

On the Mac, I used homebrew to install hhvm

on ubuntu I tried with an empty directory and .hhconfig

alex-linuxbook# touch .hhconfig
alex-linuxbook# hh_client
For more detailed logs, try `tail -f $(hh_client --monitor-logname) $(hh_client --logname)`
Server launched with the following command:
        '/usr/bin/hh_server' '-d' '/home/alex/projects/mednet/hhvm_test' '--waiting-client' '7'
Spawned typechecker (child pid=11375)
Logs will go to /tmp/hh_server/monitor_logs/zShomezSalexzSprojectszSmednetzShhvm_test-2018-01-30-11-19-03.monitor_log
No errors!

I installed the following on Ubuntu This time, I moved 4GB from the codebase(Assets and non-php/hack files) codebase is 2GB now, just incase this has to do with project file size

alex-linuxbook# hhvm --version
HipHop VM 3.24.0 (rel)
Compiler: 1516124626_976893399
Repo schema: d5bece0b5816051983d735b04543cee8156e6a49

I ran hh_client on the empty directory: No Errors! I then tried to run on the project directory: Fatal error: exception Failure("Ancient version of server sent old Build_id_mismatch")

I restarted the system and ran hh_client. it seem to work on the code base longer than before.

alex-linuxbook% hh_client
For more detailed logs, try `tail -f $(hh_client --monitor-logname) $(hh_client --logname)`
Server launched with the following command:
    '/usr/bin/hh_server' '-d' '/home/alex/projects/mednet/leonardo2' '--waiting-client' '7'
Spawned typechecker (child pid=3572)
Logs will go to /tmp/hh_server/monitor_logs/zShomezSalexzSprojectszSmednetzSleonardo2-2018-01-30-11-36-05.monitor_log
hh_server is busy: [type check] -hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
alex-linuxbook% cat /tmp/hh_server/monitor_logs/zShomezSalexzSprojectszSmednetzSleonardo2-2018-01-30-11-36-05.monitor_log 
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

Informant using dummy - resigning
[2018-01-30 11:36:05] Starting first server
[2018-01-30 11:36:05] About to spawn typechecker daemon. Logs will go to /tmp/hh_server/zShomezSalexzSprojectszSmednetzSleonardo2.log

[2018-01-30 11:36:05] Just started typechecker server with pid: 3574.
[2018-01-30 11:36:05] Got request for typechecker. Prior request 0.0 seconds ago
[2018-01-30 11:37:55] typechecker exit with exit code 16

Running hh_server check

alex-linuxbook% hh_server --check $(pwd)  
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

[2018-01-30 11:44:16] Version: hh-12123af8f51b09f36cf876adee7eed06067560af-3.24.0 Tue Jan 16 12:45:35 2018
[2018-01-30 11:44:16] Hostname: alex-linuxbook
/etc/hh.conf:
sharedmem_dep_table_pow = 32
sharedmem_hash_table_pow = 32

[2018-01-30 11:44:16] No debug port attached
[2018-01-30 11:44:16] Indexing: 0.000141
[2018-01-30 11:44:19] Heap size: 21371840
[2018-01-30 11:44:19] Parsing: 2.677838
[2018-01-30 11:44:19] Heap size: 22281600
[2018-01-30 11:44:19] Naming: 0.132650
[2018-01-30 11:44:21] Heap size: 23968832
[2018-01-30 11:44:21] Type-check: 2.026923
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
Subprocess(4107): fail 16Fatal error: exception Worker.Worker_exited_abnormally(16)
Worker exited (code: 16)
Worker exited (code: 16)
Worker exited (code: 16)
alex-linuxbook%

fredemmott commented 6 years ago

how large is your code base?
how did you settle on those hh config values? That requires 96GB of memory - (1 << 32) * 16 for the hash table, (1 << 32) * 8 for the dep table

beatscode commented 6 years ago

I tried

sharedmem_dep_table_pow = 19
sharedmem_hash_table_pow = 19

Then I cleared the file altogether. No dice. I also removed another directory bringing the project down to 1.5GB.

alex-linuxbook# hh_client
Last server exited with code: 16.
For more detailed logs, try `tail -f $(hh_client --monitor-logname) $(hh_client --logname)`
Server launched with the following command:
    '/usr/bin/hh_server' '-d' '/home/alex/projects/mednet/leonardo2' '--waiting-client' '8'
Spawned typechecker (child pid=7217)
Logs will go to /tmp/hh_server/monitor_logs/zShomezSalexzSprojectszSmednetzSleonardo2-2018-01-30-12-25-15.monitor_log
hh_server is busy: [processing] -hh_server died unexpectedly. Maybe you recently launched a different version of hh_server. Now exiting hh_client.
alex-linuxbook# cat /tmp/hh_server/monitor_logs/zShomezSalexzSprojectszSmednetzSleonardo2-2018-01-30-12-25-15.monitor_log 
/etc/hh.conf:

Informant using dummy - resigning
[2018-01-30 12:25:15] Starting first server
[2018-01-30 12:25:15] About to spawn typechecker daemon. Logs will go to /tmp/hh_server/zShomezSalexzSprojectszSmednetzSleonardo2.log

[2018-01-30 12:25:15] Just started typechecker server with pid: 7219.
[2018-01-30 12:25:15] Got request for typechecker. Prior request 0.0 seconds ago
[2018-01-30 12:25:21] typechecker exit with exit code 16

fredemmott commented 6 years ago

it sounds like you need to try other values in between those extremes

beatscode commented 6 years ago

Is there anyway to flush the hash & dep tables? I keep changing the values and the Heap, Heap size and other values stay pretty much the same when running hh_server --check I've gone as low as 10 all the way to 30. Should I be looking at sharedmem_global_size and heap_size too? What kind of defaults do these configs have?

fredemmott commented 6 years ago

Are those all getting exit code 16?

the default is 18

fredemmott commented 6 years ago

Are you able to:

delete your /etc/hh.conf entirely, so only using defaults
remove any options from .hhconfig
see if it's a specific part of your code that hh can't handle - e.g. delete half, see if it crashes. if so, delete half the remainder, and so on. If deleting it fixes it, undelete half, and recurse

beatscode commented 6 years ago

Ok so i started moving code folders to the parent directory one by one and running hh_server --check each time. I then was able to get a syntax error.. so i fixed the error (had to do with a missing & in usort function) Then one by one started putting directories back in and then finally getting a Error 16 again. The directory size is at 1.1GB I have an assets folder with just random assets and a node_modules folder left to bring in. I tried changing the values from 18 -> ( 19,20,21) but doesn't seem to help. Is there no way to tell hhvm typechecker to ignore certain directories?

fredemmott commented 6 years ago

If you're on 3.23 or above, you want something like this in your .hhconfig:

ignored_paths = [ "assets/.+", "node_modules/.+" ];

beatscode commented 6 years ago

this didn't work for me..ignored_paths = [ "storage/.+", "node_modules/.+" ]; I'm guessing this is related to https://github.com/facebook/hhvm/issues/8065

fredemmott commented 6 years ago

Closing: yes, it seems to be that hhvm issue, not specific to homebrew.

hhvm / homebrew-hhvm

Can't run hh_client #86

Description

Context and Logs

Mac

Ubuntu