hhvm / homebrew-hhvm

Official Mac OS X Homebrew formula for HHVM
MIT License
81 stars 22 forks source link

Most recent homebrew jemalloc is too new #87

Closed oyamauchi closed 7 years ago

oyamauchi commented 7 years ago

Description

After building hhvm with brew, every invocation results in this error message during startup:

<jemalloc>: Invalid conf pair: lg_dirty_mult:5

This is because that config option was removed in jemalloc 5.0.0 (source: https://github.com/jemalloc/jemalloc/blob/dev/ChangeLog#L161), which was added to homebrew-core on June 13, 2017 (source: https://github.com/Homebrew/homebrew-core/commit/7c2104a4557e1ca0aec049fb4e0804ba672faf55).

I'd suggest adding jemalloc 4.5.0 to this tap and having the hhvm formula depend on that.

Context and Logs

Parameter Value
OS X Version: 10.12.5
Homebrew Version: 1.2.3-43-g8a5f1207
Xcode Version: 8.3.3

Output of clang -v:

Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
wake-up-neo commented 7 years ago

+1 the same

mofarrell commented 7 years ago

A pull request would be great.

fredemmott commented 7 years ago

Reopening as that was reverted in https://github.com/hhvm/homebrew-hhvm/commit/cc7140fd69d0a03f0c77594e3b06d08d2faffa85

DanielDwyer commented 7 years ago

+1 happening again

oyamauchi commented 7 years ago

I never saw the issue that led to my PR being reverted, FWIW.

fredemmott commented 7 years ago

Appears fixed with 3.21