search

hieplpvip / AsusSMC

A VirtualSMC plugin provides native macOS support for ALS, keyboard backlight and Fn keys on Asus laptops
MIT License
170 stars 21 forks source link

AsusSMC 1.3.0 not working with latest available VSMC, WEG and Lilu #82

Closed Ubsefor closed 3 years ago

Ubsefor commented 3 years ago

Latest AsusSMC doesn’t work with latest commits or available for download release versions of VirtualSMC, WhateverGreen and Lilu. This may be due to daemon not starting with launchd on my system, in which case I still need help.

UPD: Version 1.2.3 works correctly even without daemon for some reason on the same versions of stated supplementary kexts

UPD2: kextstat tells that AsusSMC.kext is not loaded for some reason…

hieplpvip commented 3 years ago

Send me your EFI folder

Ubsefor commented 3 years ago

Send me your EFI folder

Here you go: (cleared serials)

EFI.zip

hieplpvip commented 3 years ago

Can you run gen-debug? I need kernel log to see why AsusSMC is not loaded.

Ubsefor commented 3 years ago

Can you run gen-debug? I need kernel log to see why AsusSMC is not loaded.

Here are two gen_debug outputs: one when using AsusSMC 1.3.0 and the other one with version 1.2.2

debug_21441_ASMC130.zip debug_21517_ASMC122.zip

Ubsefor commented 3 years ago

Ok, so I did a little digging in kernel logs myself, and discovered that in header file the setPowerState was declared as purely virtual method, but not implemented. So I removed declaration from AsusSMC.hpp, recompiled it and tested. The kext now loads and works correctly, I will create pull request, if you want to use it as temporarily solution (unless you wanted to implement setPowerState method in some way) Снимок экрана 2020-08-18 в 17 11 29

hieplpvip commented 3 years ago

Thank you very much. That's function is part of the workaround for Catalina. We don't need it anymore. Somehow I forgot to remove it.