hieuvp / react-native-fingerprint-scanner

Provide Fingerprint, Touch ID, and Face ID Scanner for React Native (Compatible with both Android and iOS)
https://www.npmjs.com/package/react-native-fingerprint-scanner
870 stars 298 forks source link

Face Scan in Android #198

Open zhuminjunivan opened 2 years ago

zhuminjunivan commented 2 years ago

if PromptInfo set setConfirmationRequired(fasle),face scan error dialog will show two negativeButton;

As shown : IMG20211110120238

set setConfirmationRequired(true) no matter

mikehardy commented 2 years ago

It sounds like you are here? https://github.com/hieuvp/react-native-fingerprint-scanner/blob/31f160f6437415258a6204ca8481612b314e41f8/android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java?#L130

What if you remove the next line so there is no cancel text? Is this device specific? Are there other reports of this?

It looks like the package ships with this configuration to start, surprising if it is not listed in the issues then, which makes me think maybe device specific :thinking:

zhuminjunivan commented 2 years ago

It sounds like you are here? https://github.com/hieuvp/react-native-fingerprint-scanner/blob/31f160f6437415258a6204ca8481612b314e41f8/android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java?#L130

What if you remove the next line so there is no cancel text? Is this device specific? Are there other reports of this?

It looks like the package ships with this configuration to start, surprising if it is not listed in the issues then, which makes me think maybe device specific 🤔

Device : Realme Q3, Android 11

zhuminjunivan commented 2 years ago

Maybe this is a system bug if I setConfirmationRequired(true),face sacn successed need to confirm; if setDeviceCredentialAllowed(true) and not setNegativeButtonText also ok;although user need to enter password,but don't affect the operation。 so advice open parameter to rn,let developer choose; Thanks

mikehardy commented 2 years ago

I am no authority in this module, but in general that seems like a reasonable thing if you wanted to make a pull request with it

zhuminjunivan commented 2 years ago

I am no authority in this module, but in general that seems like a reasonable thing if you wanted to make a pull request with it

never mind,i change it locally