search

higan-emu / higan

higan is a multi-system emulator focused on accuracy, preservation, and configurability.
Other
1.19k stars 112 forks source link

Fix EXHIROM-RAM-* board mappings. #135

Closed jchv closed 4 years ago

jchv commented 4 years ago

It is unclear why these addresses were added to the mapping. Removing these two mappings brings behavior inline with SNES9x:

https://github.com/snes9xgit/snes9x/blob/master/memmap.cpp#L2812

Corresponding bsnes change: https://github.com/bsnes-emu/bsnes/pull/96

jchv commented 4 years ago

Context from @byuu_san on Twitter: https://twitter.com/byuu_san/status/1324479722735087617

... why did I have to go and do this. That is so blatantly wrong and knocks out 896KB of my expanded translation space. I am going to have to ship it with manifests or hope they can get a new release out with that line removed.

Specifically that maps RAM on top of the lower 32KB of for the last 896KB of ROM. So technically I lose 448KB of ROM but I kind of needed the 64K bank ranges there since DMA can't wrap banks on the SNES. This only affects >56mbit ROMs, of which there are none currently.