Install app icons under default theme

ghisvail commented 4 years ago

Would be great if higan / icarus had SVG versions of their respective icons to improve their looks on large resolutions. But that's a separate issue.

jchv commented 4 years ago

Icarus seems to have an SVG: https://github.com/higan-emu/higan/blob/master/icarus/resource/icarus.svg

Higan does not, but I just tried to make one.

<?xml version="1.0" encoding="UTF-8"?>
<svg width="256" height="256" version="1.1" viewBox="0 0 256 256" xmlns="http://www.w3.org/2000/svg">
  <circle id="circle" cx="128" cy="128" r="120" fill="#ffc0c0"/>
  <path aria-label="火" d="m124 147c12.896 16.878 24.503 34.755 36.903 52 7.844 10.91 16.964 23.908 30.275 28.106 11.249 3.5474 30.665 2.4372 46.435 1.4786 6.6017-0.4013 17.116-0.5079 14.36-9.5573-1.479-4.8568-10.771-6.1831-14.98-7.6861-11.535-4.118-23.205-8.488-33.993-14.343-20.393-11.07-37.983-28.388-52.826-45.998-5.4957-6.3998-17.39-21.556-21.448-27.763 0.31921-7.5314 0.4941-15.143 0.94376-22.237 0.84897-13.383 1.8022-26.676 3.556-40 2.3235-17.651 10.153-23.467-3.8765-29.658-10.698-4.7205-24.597-10.85-28.669-4.5464-2.693 4.3359 2.7925 11.963 4.0175 16.293 2.595 9.1727 2.9358 18.577 2.8011 28.036-0.59575 41.806-2.8366 82.607-22.022 108-12.184 16.126-26.016 26.488-46.446 37.642-3.3097 1.807-17.228 6.3288-11.794 13.044 2.8383 3.5079 9.7751 1.8442 12.907 1.498 8.5652-0.94681 16.995-2.9158 24.607-6.921 31.407-16.526 52.559-40.903 59.25-77.387m54.17-72.026c-5.8049 7.358-12.506 13.377-19.153 19.929-3.722 3.6692-10.149 9.2398-12.853 13.02-3.8004 5.3131 2.308 10.467 7.4254 8.2269 15.801-6.9168 30.175-16.111 43.411-23.635 12.289-6.9861 16.406-5.5387 18.541-9.043 2.5685-4.2158-0.71064-9.3778-5.7571-14.809-5.5034-5.923-15.476-14.836-22.388-11.58-4.982 2.3463-4.1686 5.8154-4.6938 9.7959-0.3238 2.4543-2.3628 5.3448-4.5325 8.095zm-130.93-4.1005c-5.9221 4.1648-1.0214 11.922 1.0418 16.129 4.0739 8.3075 10.748 17.819 17.381 24.331 4.4225 4.3424 9.1036 6.9238 13.359 3.9335 3.7764-2.6537 5.8307-8.9441 5.9633-13.28 0.38934-12.729-10.785-21.148-21.983-26.998-3.9144-2.0448-11.327-7.2351-15.762-4.1159z" fill="#e01b1b"/>
</svg>

Which renders like: higan-ui-rendered

I can put it in a separate PR. Are there any specific things SVG icons should do to be more "compatible"? Should I remove width/height attributes and just keep the viewbox?

ghisvail commented 4 years ago

Higan used to have an SVG icon, whilst byuu and icarus did not. I have looked at v110 mostly since it's the version Linux distros seem to be stuck at until the higan-ui refactoring is done.

ghisvail commented 4 years ago

@jchv perhaps reintroducing the SVG from v110 is enough? Am I happy to submit a PR if time is limited on your end.

jchv commented 4 years ago

Ahh, cool, I missed that.

Time is not too limited on my end but feel free, you'll probably beat me to it anyways.

ghisvail commented 4 years ago

See #141

ghisvail commented 4 years ago

@jchv I think we are missing an SVG for byuu, am I correct?

jchv commented 4 years ago

Seems as though you are correct. It should be relatively easy to work backwards and make one, though. Shall I do that?

ghisvail commented 4 years ago

Please go ahead if you can 👍

Le dim. 8 nov. 2020 à 21:04, John Chadwick notifications@github.com a écrit :

Seems as though you are correct. It should be relatively easy to work backwards and make one, though. Shall I do that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/higan-emu/higan/pull/138#issuecomment-723658505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAO7U3ZYWEPFQWNXLRDMYIDSO32UHANCNFSM4TMSULNA .

jchv commented 4 years ago

Alright, did so at #143.

ghisvail commented 4 years ago

Please do not merge as it is not complete yet. It would be nice to have #141 and #143 merged first :+1:

higan-emu / higan

Install app icons under default theme #138