search

higan-emu / higan

higan is a multi-system emulator focused on accuracy, preservation, and configurability.
Other
1.19k stars 112 forks source link

hiro: Defer menubar updates on Windows to reduce flicker. #146

Open jchv opened 4 years ago

jchv commented 4 years ago

Menu bar updates are deferred to the event loop. A special case is made when no menu bar is visible, to ensure one is visible as early as possible during application startup.

Old New
byuu with current hiro, menu flickers byuu with hiro from this PR, no menu flicker
bsnesFan commented 3 years ago

This fix is working with bsnes as well. That's cool. =)

Do you think it is possible to fix this insane flickering issue in the settings there as well, @jchv

https://user-images.githubusercontent.com/79463574/108847316-dc5a6300-75df-11eb-8288-ee7dbd1b3c90.mp4

jchv commented 3 years ago

I've looked into it but it may not be trivial. :)

bsnesFan commented 3 years ago

@jchv: Thank you very much for your response and that you looked into that! That's unfortunate. But what I realized is that ares has the same gui and it hasn't this problem anymore. Seems like Near changed something. Maybe you can see there what exactly the problem is. That would be really cool. That's basically the only thing that bothers me, when I'm using bsnes. ^^;

setthh commented 3 years ago

He did something in this commit: https://github.com/bsnes-emu/bsnes/commit/56c9a5195e48d3d88ea5637ca3dcb236d9f0dd1f Maybe this will help to identify the problem.

And we have the source code of ares for comparison: https://github.com/higan-emu/ares