highcharts / highcharts-editor

https://www.highcharts.com/products/highcharts-editor
Other
249 stars 96 forks source link

Change meta for border radius to have a min=0 #16

Open cvasseng opened 8 years ago

cvasseng commented 8 years ago

Note that this was actually caused by number types not taking min/max into consideration. Once that was added, it worked as the meta from the chart cloud already had these properties for border width (and others).

However, I will be adding min/max/step to the API docs themselves also to limit the amount of configuration data required in the editor-specific meta.

TorsteinHonsi commented 8 years ago

When adding this to the database docs, perhaps it is a good idea to nest them in an editor object so we don't pollute the basic documents?

[...]
"fullname": "chart.borderWidth",
"editor": {
  "min": 0,
  "step": 1,
  "max": 20
},
[...]
cvasseng commented 8 years ago

Yeah, I think that's a good idea. Maybe call it something else than editor though to make it more general? meta or something? I don't know.

TorsteinHonsi commented 8 years ago

Yes, unless meta is too general :) But I think it's a fair point, we may want to use these props for other things than an editor GUI. Currently the use case is the Cloud, the Editor and third party editors like Highcharts GWT and EasyCharts.

cvasseng commented 8 years ago

constraints would perhaps work for these types of properties, but there may be others we want to include too that aren't "constraints"..

It's like they say; there are only two difficult things in computer science - naming things and cache invalidation..

TorsteinHonsi commented 8 years ago

Yes, like constraints.friendlyTooltipTextForNonTechies :)