search

hiltontj / serde_json_path

Query serde_json Values with JSONPath
https://serdejsonpath.live/
MIT License
50 stars 3 forks source link

Clean up `TODO`s #69

Closed hiltontj closed 8 months ago

hiltontj commented 10 months ago

Grep for "TODO" yields the following:

serde_json_path/src/parser/primitive/int.rs
53: // TODO - I don't know if this following test demonstrates the actual behaviour we want

serde_json_path_core/src/spec/selector/slice.rs
95: let start_default = self.start.unwrap_or(len - 1); // TODO - not checked sub
96: let end_default = self.end.unwrap_or(-len - 1); // TODO - not checked sub

serde_json_path/src/parser/segment.rs
20: // TODO - I have no idea if this is correct, supposed to be %x80-10FFFF

serde_json_path/src/parser/selector/filter.rs
239: // TODO - test more

serde_json_path_macros/src/internal/func/args.rs
22: // TODO - may want to warn here when found a invalid arg - see how

serde_json_path_macros/src/internal/common/extract.rs
46: // TODO - support full type path to ensure that correct type is being used?

These need to be cleaned up.