search

hindley-milner-systems / dapp-ertp-airdrop

0 stars 2 forks source link

add offer filter for pausing contract #86

Closed tgrecojs closed 1 month ago

linear[bot] commented 3 months ago

LAR-124 add offer filter for pausing contract

tgrecojs commented 2 months ago

pause method is added in PR #99

implementation

https://github.com/hindley-milner-systems/dapp-ertp-airdrop/blob/86b493d6bb10fe0f82e1070d1f240feae32e7340/contract/src/airdrop/airdropKitCreator.js#L335-L337

test code

https://github.com/hindley-milner-systems/dapp-ertp-airdrop/blob/86b493d6bb10fe0f82e1070d1f240feae32e7340/contract/test/tribbles-airdrop/contract.test.js#L199-L233

tgrecojs commented 2 months ago

@dckc added references to code above. pinging you for the 👍 before closing.

dckc commented 2 months ago

It's hard for me to advise, since #99 isn't green in ci (#57). I checked a recent ci log but the test name pause method doesn't occur.

And it would be easier if there were a PR about just this issue, and not all the stuff that's in #99. Then the normal "fixes #86" would automatically close this once the PR is green and merged.

tgrecojs commented 1 month ago

closing ... see #109 for remaining tasks.