search

hippalectryon-0 / xr-scipy

scipy for xarray eco-system
http://xr-scipy.readthedocs.io
61 stars 9 forks source link

Refactor FFT #3

Closed fujiisoup closed 1 year ago

fujiisoup commented 6 years ago

Xarray.apply_ufunc now disallow to change the dimension size of input_core_dims. xrscipy.fft uses this. needs update.

Also, it might be reasonable to merge fft and fftn function.

hippalectryon-0 commented 1 year ago

Dimension change done in dev0.

In the current state I'm not sure we want to merge fft and fftn, they don't have the same signature in scipy. Feel free to reopen if necessary.