search

hippalectryon-0 / xr-scipy

scipy for xarray eco-system
http://xr-scipy.readthedocs.io
61 stars 9 forks source link

Do you really need the newest xarray>=2023 dependency? #35

Open smartass101 opened 1 year ago

smartass101 commented 1 year ago

xrscipy used to work just fine with older xarray versions, so unless you really need xrscipy>=2023, please don't introduce such a strict dependency which prevents simple xrscipy installation in older environments (in scientific environments and clusters one does not always have a choice).

hippalectryon-0 commented 1 year ago

Can you expand on which setting would not allow bumping xarray>=2023 ?

Unlike libraries like cartopy which rely on compiled libraries like libgeos, xarray is easily installed via pip/... without any special account rights.

Moreover, what's preventing the occasional users that really can't install this requirement to simply install an older version of xrscipy ?

xarray has undergone a number of improvements over the past years, some of which are breaking, and I can't guarantee that the current code would run exactly the same with older versions of the library.

smartass101 commented 1 year ago

xarray is easily installed via pip/... without any special account rights.

In typical circumstances yes, but not so easily on larger cluster systems or scientific environments where very often only certain Python environments and setups are supported and going outside them (e.g installing a a user pip or conda env) can be very difficult (loss of functionality in terms of specialized libraries). Often they may even have xarray installed and used by some software, but an older version than 2023.

Moreover, what's preventing the occasional users that really can't install this requirement to simply install an older version of xrscipy ?

This may indeed be a workaround for those that really need it, but such a hurdle needlessly lowers the possible appeal of xrscipy to such users.

xarray has undergone a number of improvements over the past years, some of which are breaking, and I can't guarantee that the current code would run exactly the same with older versions of the library.

If the xrscipy test suite passes with an older version of xarray, it should be fine. xrscipy does not really use the newest bells and whisles.

hippalectryon-0 commented 1 year ago

If the xrscipy test suite passes with an older version of xarray, it should be fine. xrscipy does not really use the newest bells and whisles.

I'd agree with you if the test suite was actually complete, but as it stands only fft and integrate are properly tested.

If you feel like adding more test coverage (via PR), I'd be happy to integrate it and then find the oldest version of xarray that pass all tests.