hippalectryon-0 / xr-scipy

scipy for xarray eco-system
http://xr-scipy.readthedocs.io
61 stars 9 forks source link

Supported python versions #47

Closed ckutlu closed 6 months ago

ckutlu commented 6 months ago

Hello @hippalectryon-0, I was wondering if it would be possible to relax the python requirements, preferably matching the one in xarray which is:

requires-python = ">=3.9"
hippalectryon-0 commented 6 months ago

The reason why we require 3.10 is to allow using "|" in python typing hints, which is only available from 3.10 onwards. If for some reason you are on an environment where you are limited to 3.9 (which shouldn't happen in 2024!), one workaround would be to blame your outdated server administrators fork the repository, remove the type hints from the code, and pip install using your new repository.

ckutlu commented 6 months ago

Thanks for the reply. The reason why we need to support 3.9 is a bit more complicated than updating our environment (and somewhat typical if you ask my opinion): We serve code to people who may still want to use python 3.9 (unfortunately we can't really force them what to use). I understand your point about the type hints. If having union type expressions is the only blocker, I'd recommend using from __future__ import annotations which provides the backport of that feature. I'd be happy to make the necessary changes and make a pull request if you agree with that approach. Whatever your response might be, I totally understand where you are coming from and definitely don't want to sound pushy with a feature request here. I greatly appreciate the work you've put into this library :rocket:

hippalectryon-0 commented 6 months ago

Feel free to go ahead and submit a PR ! I'll happily merge it :)

hippalectryon-0 commented 6 months ago

Let me know if 2.1.0 works fine for you :)

ckutlu commented 6 months ago

Works like a charm :) Many thanks.

Side note: I realized I forgot to add any changelog entry to my PR and now the changelog for 2.1.0 is rather empty. Do we need a PR for that?

hippalectryon-0 commented 6 months ago

Write it here and I'll edit it to the github release

ckutlu commented 6 months ago

How about this:

Add support for python 3.9 and 3.12.

hippalectryon-0 commented 6 months ago

done! feel free to close the issue :)