histocartography / hact-net

MIT License
70 stars 14 forks source link

There are bugs in some codes #4

Open mantras-cloud opened 2 years ago

mantras-cloud commented 2 years ago
  1. in dataloader.py: function _load_cg and function _load_tg: As shown in the figure,the 'cg_fnames'(line 69) and the 'tg_fnames'(line 84) has included the full path, so the code in line 73 and line 88 shoule be modified as shown in their respective next line. image
  2. in histocartography/ml/models/hact_model.py : function _compute_assigned_feats:As shown in the figure,the code in line 171 should have brackets at the end. Besides, the code in line 175 should be modified as in line176. image
  3. in histocartography/utils/graph.py function set_graph_on_cuda(graph): the code should add some as shown in the red box in the figure. image

Maybe some of these problems are caused by my computer hardware, but I did make the above changes while debugging your code. And thank you very much for your work, which has benefited me a lot. looking forward to your reply!