search

hiteshjoshi / node-stanford-corenlp

A simple node.js wrapper for Stanford CoreNLP.
Other
75 stars 35 forks source link

Support for CoreNLP-3.6 #16

Closed Illizian closed 8 years ago

Illizian commented 8 years ago

Hi, thanks for the library.

I require the latest core (3.6.0) to make use of the OpenIE annotator. It seems your library works perfectly with the latest core with one change to the loadLibrary() method as it now makes use of SLF4J library.

function loadLibrary(path,version){
    java.classpath.push(path+"/slf4j-api.jar");
    java.classpath.push(path+"/slf4j-simple.jar");
    // [...]
}

Correct me if I'm wrong but it doesn't appear to cause issues adding incorrect classpaths (as I discovered when I typod slf4j) so it doesn't seem like a version check is required?

Happy to make a PR if you can advise on how to handle this with 'backward compatibility'.

hiteshjoshi commented 8 years ago

Send a pull request.

Illizian commented 8 years ago

Thanks @hiteshjoshi - PR #19 is in