search

hitmeister / api-sdk-php

Kaufland.de Onlineshop (former real.de and Hitmeister) API SDK for PHP
https://www.real.de/api/v1/
MIT License
23 stars 29 forks source link

Fix Mimio Object issue #87

Closed abdul-jabbar01 closed 4 years ago

abdul-jabbar01 commented 4 years ago

This PR is related to this ticket. Goal of this ticket is to fix the minio issue that we are having right now while generating constants.php by generate script. Further details are mentioned in the ticket.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.7%) to 92.57% when pulling 0faa7f76d87219537d459e1b83125bb63186295e on abdul-jabbar01_DLV-321_Fix-mimio-object-issue into 20e13947229cee748c8c42a66bfbfab71077f49d on develop.

johnholiver commented 4 years ago

First of all, maybe I got this wrong... With this change, aren't you stating that our sdk consumers must have PHP 7+? If so... then I think we have a problem. You can't just push this branch and lock out everyone using PHP 5.x, there has to be communication with our software partners. Again, I didn't though this super hard. I'm just putting it out so maybe other guys can deflect my concern and we move on happily ever after.

abdul-jabbar01 commented 4 years ago

Yes. You are right. After updating it, we are forcing everybody to use at least PHP 7.0 for it. Can somebody please update that what should be the next step ? How to communicate with our software partners Or when we can update to PHP7.0 for this SDK?

As our ticket is blocked by this PR. Many thanks in advance

marein commented 4 years ago

Hello, @johnholiver correctly pointed this out. A version bump should be well thought. Software partners using PHP <7.0 can continue to use the old version and nothing will break for them, but they probably won't get your new constants (hence carriers). To unblock you: the solution to your problem would be to run this script with PHP <7.2. object has been declared as a reserved keyword since PHP 7.2.

Thoughts for the future: Bumping to new technologies is generally a good thing, especially to the latest PHP version. However, keep in mind that we need to work closely with our software partners to make such a change. The alternative would be to support multiple versions (I guess that's not what we're aiming for). Contact "Seller Management" and they will take care of it.