hitontology / ontology

The Health IT Ontology.
https://hitontology.eu/
Creative Commons Zero v1.0 Universal
3 stars 2 forks source link

SHACL is not run automatically anymore #123

Closed KonradHoeffner closed 3 months ago

KonradHoeffner commented 3 months ago

Maybe something changed that pushes from within other actions don't trigger branch push triggers in other actions anymore?

name: SHACL

on:
  workflow_dispatch:
  push:
    branches:
      - dist

jobs:
  shacl:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v4
        with:
          ref: 'dist'

      - name: Build and Validate
        uses: konradhoeffner/shacl@v1
        with:
          data: all.ttl
          shacl: shacl.ttl
KonradHoeffner commented 3 months ago

I think we had that problem somewhere else. Anyways, it is described at https://github.com/orgs/community/discussions/37103.

KonradHoeffner commented 3 months ago

After some research, this is surprisingly tricky:

So I see two options:

  1. triggering the SHACL workflow manually
  2. letting the SHACL workflow work from the master branch, not dist

Option 2 is preferable.

The SNIK ontology SHACL workflow does already work like that, by testing each Turtle file separately, but HITO only validates when all files are merged.

KonradHoeffner commented 3 months ago

The problematic files are:

Unfortunately they seem to depend on several other files and the -e option to designate an ontology does not change anything. Because of the large disparity between the low expected time saving for our infrequent releases and the effort of finding the best suited workaround, this will not be worked on right now but we may reopen this in the future if a better solution arises.