Closed jerefrer closed 11 years ago
Yes, I think that's okay.
(Just did a bad commit, if you had emails just forget those, another pull request will come ;))
Ok it's done (the typo was present in the original tests. I replaced it there as well)
And thank you!
You should make PR only from topic branches, never from master.
Note: If a PR starts from a master, you are probably wrong.
Yep I just realized that !
Third PR will come in a branch :D
2013/8/5 Jan Philipp notifications@github.com
You should make PR only from topic branches, never from master.
Note: If a PR starts from a master, you are probably wrong.
— Reply to this email directly or view it on GitHubhttps://github.com/hlsolutions/jquery-autosuggest/pull/19#issuecomment-22112571 .
What do you think ? IMHO I don't see why we don't already do this.