Review

[dajare]

• [x] typogrify - makes a number of changes which should be accepted (all commas before em-dashes)
• [x] semanticate - makes a change to c38/l31 which should be accepted; it will also change "V." to roman numeral in cc. 39 and 67 which should be rejected (you could just run se semanticate path/to/chapter-38.xhtml to target that one change)
  • [x] but cc. 39 and 67 each need a class="eoc" included in the closing abbr tag; I think these are the only two instances of this, but maybe worth a quick (regex?) check of your own.
  • [x] there are five blockquote letters in which the "To..." line has the semantic title; this looks rather like a recipient, I think. A search on type="title">To will bring up all of them (depending on your editor!).
  • [x] the blockquote @ c54/l79 needs the epub:type="z3998:letter" semantic
  • [x] in dedication.xhtml, the <h3> tags should be <p> instead: SEMoS
• [x] build-toc - for some reason, spine in content.opf does not match ToC:
  · spine: dedication -> inscription
  · toc : inscription -> dedication
  build-toc corrects toward the spine ordering; confirm which is correct, and re-run build-toc
• [x] 0c1d8e9 - is a "correct typos" commit, but looks like "[Editorial] modernize spelling" to me; if so, do rebase to modify the commit message (it looks like it should just have been rolled in with the next commit, 1c468f5, anyway, which is Editorial).
• [x] af323a0 - removing italics from loanwords now in MW - commited as [Editorial], although I think generally this is only changing formatting, not "content", so not [Editorial], and can be renamed in rebase.
• [x] all caps two cases need "lowering": (1) EVELINA in footer of letter in c30; (2) O LIFE! in poem of c42 (just "life", in this case of course).

Metadata

• [x] Wiki link for author in both colophon.xhtml and content.opf might as well be: https://en.wikipedia.org/wiki/Frances_Burney
• [x] nacoaf in content.opf @ line 78 needs to be URI = http://id.loc.gov/authorities/names/n80075853
• [x] Final paragraph of long description: Austen-who...letters-and > both hyphens need to be em-dashes (—).

Comment In local.css, the letter/poetry+verse rules appear to be jumbled. Normally the different rules are marked out by "type" in comment lines, as this makes reviewing them much easier. Nicholas Nickleby provides a good recent/random example. For future projects!

[hlund05]

I've made all the updates requested above. I also re-organized local.css - thanks for linking to that example, it makes a lot of sense.

One follow-up question: In addition to commas, the author also places a lot of semicolons and colons before em dashes. Are these OK to leave in place? Typogrify doesn't seem to object to them.

Thanks!

[dajare]

Those changes look good - even a couple tweaks I missed!

One follow-up question: In addition to commas, the author also places a lot of semicolons and colons before em dashes. Are these OK to leave in place? Typogrify doesn't seem to object to them.

Generally, if there are cases that typogrify doesn't object to or alter, and there are no instructions in the Step-by-step guide to cover "gotcha's", then it's usually okay to leave them. The best thing always is to check SEMoS, in this case the typography section. Also, one can do a code search on SE's Github repos. In this case, you'll see there are MANY instances of colon/semi-colon before em dashes.

So the short answer ;-) is: yes, it's okay to leave them. [EDIT Actually, I see many cases of comma->emdash, too, so not quite sure I spotted correctly what typogrify was doing: the more important thing, in this case, is that typogrify needed to be re-run, so we got that!]

I think this is ready to pass on to Alex, then; I'll flag it up on Google Groups.