hmc-whisk / jsLDA

A React based version of jsLDA with brand new features added on
Other
0 stars 0 forks source link

Max topic saliency value remains unchanged after removing stop words #163

Open theobayard opened 3 years ago

theobayard commented 3 years ago

This means if you're looking at documents, don't like that only pronouns (or whatever) are being highlighted and then go remove said pronouns, when you go back to look at documents, the only difference will be that those words you removed aren't highlighted. The other words won't have increased their highlighting now that the maximum saliency value is lower.

I think this is because I did some funky memoizing stuff to avoid having to calculate maximum topic saliency over and over again because it takes forever. Simply making it so the memoized value is deleted when stopwords are added (or removed now that I think of it) should then fix the problem.