search

hms-dbmi / spp

SPP - R package for analysis of ChIP-seq and other functional sequencing data
39 stars 22 forks source link

new release? #15

Closed daler closed 7 years ago

daler commented 7 years ago

@pkharchenko would you mind releasing a new version that has the updates at least in https://github.com/hms-dbmi/spp/commit/b252e090b70e0a2308e6d6829fab6f2f7c041291? The current version 1.14 is still broken for BAM files.

pkharchenko commented 7 years ago

Hi Ryan, Haven’t had time to look at this, unfortunately. Is there a fix for the bam files that’s been checked in? Actually, I can’t find an issue on the bam parsing. An example would be great to have. Thanks, -peter.

On Jul 3, 2017, at 5:16 PM, Ryan Dale notifications@github.com wrote:

@pkharchenko https://github.com/pkharchenko would you mind releasing a new version that has the updates at least in b252e09 https://github.com/hms-dbmi/spp/commit/b252e090b70e0a2308e6d6829fab6f2f7c041291? The current version 1.14 is still broken for BAM files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hms-dbmi/spp/issues/15, or mute the thread https://github.com/notifications/unsubscribe-auth/ALT78ljxH9S1tVvG0q-IXRzNVDJRePf-ks5sKVo1gaJpZM4OMsMF.

daler commented 7 years ago

You already have the fix here: https://github.com/hms-dbmi/spp/commit/b252e090b70e0a2308e6d6829fab6f2f7c041291, and there are some other fixes later than that in the master branch. There's just no release yet that includes those changes. All you should need to do is create a new tag (e.g, 1.15) and push that to github. Github will then build a new tarball automatically and make it available in https://github.com/hms-dbmi/spp/releases.

Then over in https://github.com/bioconda/bioconda-recipes we can build a new package based on that tarball.

Thanks.