Off-by-one error on vol command

hnarayanan / shpotify

A command-line interface to Spotify.

https://harishnarayanan.org/projects/

2.02k stars 153 forks source link

Open ghost opened 4 years ago

ghost commented 4 years ago

Screen Shot 2020-10-22 at 00 21 06

"spotify vol show" and "spotify vol up/down" results are off by one

hnarayanan commented 4 years ago

I honestly do not know how to fix this. This has been an error since the beginning of this project.

davidem commented 3 years ago

It's a funny applescript thingy. No idea why... but if I set the volume using a direct api call it is no longer off-by-one.

(never mind the white output, thats for quick debugging only)

If needed I'll update it and create PR.

hnarayanan commented 3 years ago

It is not needed but it will be appreciated. 😸 If it is a small change, please do raise a PR.

davidem commented 3 years ago

Ah, I now see there already is a 'dirty' +1 fix 😎, waiting to be merged... #146